Move the ava-files package back into core
#1196
Conversation
| @@ -44,7 +44,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "test": "xo && nyc tap --no-cov --timeout=150 test/*.js test/reporters/*.js", | |||
| "test-win": "tap --no-cov --reporter=classic --timeout=150 test/*.js test/reporters/*.js", | |||
| "test-win": "tap --no-cov --reporter=classic --timeout=150 test/ava-files.js test/reporters/*.js", | |||
There was a problem hiding this comment.
You forgot to change this back ;)
There was a problem hiding this comment.
Oups ! I'm unmasked, I test under windows!
| @@ -0,0 +1,180 @@ | |||
| const path = require('path'); | |||
There was a problem hiding this comment.
Put 'use strict'; above here.
sindresorhus
changed the title
ava-files package back into core
|
There are some lint issues you need to fix. See Travis. |
|
Some tests are failing: https://travis-ci.org/avajs/ava/jobs/193048227 |
|
@sindresorhus I will look at these tests quickly. Sorry There is a second point to consider: spread for Node 4 (https://travis-ci.org/avajs/ava/jobs/193048228#L231). |
|
No, only use syntax supported on Node.js 4. |
I assume it's used in the old tests? We're using AVA to run those tests, and of course AVA takes care of transpiling the spread operator. That's not the case with tap. |
|
@sindresorhus ok, i will remove spread @novemberborn Obviously, how could I miss out on this? I will read the doc in French! 😄 |
remove spread for comptability node 4
|
All tests passing. Sorry for my mistakes. |
🥇 tough leadership decisions |
|
This is awesome. Thanks @forresst! |
Fixes #1192