Skip to content

Thoughts on CLI flags #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
novemberborn opened this issue Sep 23, 2016 · 5 comments
Closed

Thoughts on CLI flags #1048

novemberborn opened this issue Sep 23, 2016 · 5 comments
Labels

Comments

@novemberborn
Copy link
Member

Came across this comment from @jamestalmage:

My feeling on options via cli.js: We should only add those where users would conceivably want to temporarily override the contents of their package.json config. Allowing different reporters on CI servers, running in --serial mode occasionally to debug, these are good examples.

I quite like this! Maybe it should be our "official" stance.

I think that'd mean --require has to go. On the other hand the --source flag may have to stay (as opposed to #937). We shouldn't have --extension either (#631).

Thoughts?

@sindresorhus
Copy link
Member

@novemberborn I agree, but what other flags would we remove?

On the other hand the --source flag may have to stay

Why?

@novemberborn
Copy link
Member Author

other flags would we remove?

Just require I think. Ideas for more?

On the other hand the --source flag may have to stay

Why?

To restrict watch mode on the fly to a more specific pattern.

@jamestalmage
Copy link
Contributor

To restrict watch mode on the fly to a more specific pattern.

That seems unlikely to be truly useful. Why would you want to avoid rerunning when certain sources change, but not others?

@vadimdemedes
Copy link
Contributor

I think --require and --source are the only ones that can safely go away. All the other ones are quite useful, don't think there's more room for removal.

@novemberborn
Copy link
Member Author

Great! I've updated the relevant issues and opened #1069 to remove the --require flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants