Remove --require CLI option (completes #1069) #1070
Conversation
jacobkahn
force-pushed
the
remove-require-cli-flag
branch
from
58923ae to
f94b58d
Compare
|
I'm sure many people use |
There was a problem hiding this comment.
Agreed with showing a warning when --require is used. See https://github.com/jacobkahn/ava/blob/f94b58df23202749691e3e82305486efd6a9854d/cli.js#L119 for an example of how we check for --tap flags when watch mode is used.
| @@ -129,7 +126,6 @@ if ( | |||
| var api = new Api({ | |||
| failFast: cli.flags.failFast, | |||
| serial: cli.flags.serial, | |||
| require: arrify(cli.flags.require), | |||
There was a problem hiding this comment.
Before, cli.flags.require would default to the config from package.json, through this line. Api still needs the require option, so this should now be require: arrify(conf.require),.
|
And wow @jacobkahn that was quick! |
|
Re-added that arg into API - thanks for catching that. Right now the deprecation message mentions the docs, then exits. Do we think this behavior is alright? |
|
🎊🎉 Thanks @jacobkahn! If you're up for another challenge, #937 is fairly similar 😄 |
This completes #1069 as part of #1048 - removes
--require/-rfrom the CLI interface, corrects documentation where relevant, modifies CLI tests accordingly.Not sure if it makes sense to add a deprecation notice or any clarifications to docs - these changes remove mentions of the flag and defer to
package.jsonconfiguration guidelines.