-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Show clear indicator in the output when .only()
is used
#1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This happened to me yesterday |
@tjbenton I would recommend using our ESLint plugin, which would have caught that and many other things. |
@ThomasBem Go for it! 😄 |
After looking at the code its really easy to get this to print out a warning similar to what was done for the #1134 issue in the #1160 PR. I was thinking about changing the logic around counting tests when in .only / exclusive mode. I did some quick testing and I could make it at least count all the tests in files that does NOT contain any .only tests. This would look something like this: If all test files have at least one .only test in them, it logs this: If there are additional test files that do not contain any .only tests, it logs this: remainingTests would then be the number of tests in the files without exclusive tests in them. Any thoughts around this? |
Perhaps instead of |
I agree, that wording is much better. Any thoughts regarding if there is any point to adding additional details around a number of tests skipped? |
It's easy to forget and end up not running the rest of the tests before pushing changes.
Similar to #1134.
The text was updated successfully, but these errors were encountered: