Skip to content

Diffs for arrays of strings can be pretty confusing #1521

Open
@lukechilds

Description

@lukechilds

If you do t.deepEqual (and I think also t.is) on two arrays containing strings. If there are a large amount of strings and they only differ slightly the output is very confusing. It appears that as soon as a new entry in an array has shifted the items after it across, AVA text diffs every single entry against the same index in the original array.

e.g: An array with 219 strings that has had 6 additions and 1 deletion:
AVA diff: https://travis-ci.org/lukechilds/window/jobs/266859856
GitHub diff: lukechilds/window@6ecbade

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions