Skip to content

Support code expectation in t.throws() #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
novemberborn opened this issue Feb 13, 2018 · 1 comment
Closed

Support code expectation in t.throws() #1708

novemberborn opened this issue Feb 13, 2018 · 1 comment
Labels
enhancement new functionality help wanted scope:assertions

Comments

@novemberborn
Copy link
Member

novemberborn commented Feb 13, 2018 •
edited
Loading

#1704 introduces an expectation object for t.throws(). It'd be neat if we could add an expectation for the code property in Node.js.

We could consider supporting errno as well. I suspect code may be the more future proof property though, in which case I wonder if errno support is really needed.
@sindresorhus
Copy link
Member

👍 to code, 👎to errno.

jamiebuilds added a commit to jamiebuilds/ava that referenced this issue Feb 14, 2018
@jamiebuilds
Support err.code in t.throws() expectation (avajs#1708)
39ceb34
jamiebuilds added a commit to jamiebuilds/ava that referenced this issue Feb 14, 2018
@jamiebuilds
Support err.code in t.throws() expectation (avajs#1708)
44a4769
@jamiebuilds jamiebuilds mentioned this issue Feb 14, 2018
Merged
@novemberborn novemberborn mentioned this issue Aug 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement new functionality help wanted scope:assertions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@novemberborn @sindresorhus