Remove ifError assertion?

[novemberborn]

Should we remove the t.ifError() assertion? It's functionally equivalent to t.falsy(). I suppose it's meant to be a "fail test if this variable contains an error" kind of assertion:

test.cb('look no error', t => {
  obj.asyncWithCallback((err, result) => {
    t.ifError(err); // Guard against there being an error
    t.is(result.value, 'bob'); // Now access `result`
    t.end(); // Aaaand done!
  });
});

This is odd though. t.end() can be passed an error, and besides we don't stop running the test implementation when an assertion fails so it doesn't do anything useful.

@avajs/core?

[sindresorhus]

It was useful early on when callbacks were the main async thing and we didn't have as good assertion output as we have today. It doesn't make much sense today, so I agree we should remove it.

[novemberborn]

@kugtong33 since you reminded me to raise this, it's yours if you want it! 😉

[Jolo510]

@novemberborn To remove the ifError assertion, is it just removing it from the assert.js file?
https://github.com/avajs/ava/blob/master/lib/assert.js#L464

And potentially fixing any tests that uses the ifError?

Also, since it's a breaking change, what's the rules for versioning AVA?

[novemberborn]

@Jolo510 yup. The type definitions and documentation need to be updated sa well.

since it's a breaking change, what's the rules for versioning AVA?

We're currently doing 1.0 beta releases so there's no concern.

[Jolo510]

@novemberborn Gotcha! @kugtong33 you get first dibs!

[kugtong33]

@novemberborn @Jolo510 , on it