Skip to content

Disallow null expectations for throws and throwsAsync assertions #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
novemberborn opened this issue Feb 23, 2020 · 3 comments · Fixed by #2576
Closed

Disallow null expectations for throws and throwsAsync assertions #2410

novemberborn opened this issue Feb 23, 2020 · 3 comments · Fixed by #2576
Assignees
@novemberborn
Labels
breaking requires a SemVer major release scope:assertions scope:typescript
Milestone
4.0

Comments

@novemberborn
Copy link
Member

As a follow-up to #2401, for the next major AVA release we'll remove support for null expectations in throws and throwsAsync assertions. If you want to specify a message without any other expectations you should set it to undefined instead.

This can partially land behind an experimental flag, to be unflagged when the next major is (pre-)released. The the TypeScript definition can only be updated at that point.
@TokenStyle TokenStyle mentioned this issue Mar 12, 2020
Closed
@JSimoni42 JSimoni42 mentioned this issue Sep 6, 2020
Merged
@JSimoni42
Copy link
Contributor

Hey @novemberborn, I noticed that the previous PR for this one was closed out and put together a similar fix. I browsed https://github.com/avajs/ava/blob/master/.github/CONTRIBUTING.md and believe that this PR checks all the boxes, but any feedback would be appreciated.

@novemberborn
Copy link
Member Author

Re-opening for the AVA 4 milestone, when we can remove the experimental flag and make this the default behavior.

@novemberborn novemberborn reopened this Sep 9, 2020
@novemberborn novemberborn self-assigned this Sep 9, 2020
@novemberborn novemberborn added this to the 4.0 milestone Sep 9, 2020
@novemberborn
Copy link
Member Author

Plus update the TypeScript definition.

novemberborn added a commit that referenced this issue Feb 7, 2021
@novemberborn
Disallow null expectations for throws() and throwsAsync() assertions
d3a9dc7 
Fixes #2410.
bunysae pushed a commit to bunysae/ava that referenced this issue Feb 14, 2021
@novemberborn @bunysae
Disallow null expectations for throws() and throwsAsync() assertions
1b59359 
Fixes avajs#2410.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novemberborn novemberborn

Labels
breaking requires a SemVer major release scope:assertions scope:typescript
Projects
None yet
Milestone
4.0
2 participants
@novemberborn @JSimoni42