Have assertions return booleans

[novemberborn]

Spurred by conversation in #2449 and #1485 we'd like for our assertions to return booleans. true when they pass, false when they fail. This does not apply to the throws() and throwsAsync() assertions.

Failing assertions will fail the test, but do not throw exceptions. This means your test does not stop executing. Usually that's fine, but there are conditions where you're about to do something that uses a lot of resources, and it's already unnecessary. Returning booleans will help with this.

The assertions are defined here:

ava/lib/assert.js

Line 238 in 18aeac6

class Assertions {

The type definition should be updated to reflect the new return type:

ava/index.d.ts

Line 41 in 18aeac6

export interface Assertions {

Some tests should be added to (or existing test updated in) https://github.com/avajs/ava/blob/master/test-tap/assert.js.

[aviralch]

Hello,

can i work on this ?

[novemberborn]

@aviralch yea that'd be great, thanks!

[pmascheroni]

Hi, @novemberborn I am also attempting an update to this issue and wondering if I could be assigned to it too? Not sure if that is allowed, but I would like to work on this also.

Thanks

[novemberborn]

@pmascheroni let's give @aviralch a chance first.

[aviralch]

@novemberborn, @pmascheroni this is my first issue, I will try to do this and keep you updated by the end of of week.

[BARICISSE]

Hi, if no one is currently working on this and it is still open, i would like to contribute.

[novemberborn]

@aviralch what do you think?