Skip to content

Use promises #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sindresorhus opened this issue Sep 6, 2015 · 0 comments
Closed

Use promises #38

sindresorhus opened this issue Sep 6, 2015 · 0 comments
Labels
enhancement new functionality help wanted

Comments

@sindresorhus
Copy link
Member

We do a lot of async stuff in AVA. Would be cleaner by using promises instead.

For example here: https://github.com/sindresorhus/ava/pull/36/files#diff-b3b53682a18f203ac8d29b0e277cad26R97

Should use https://github.com/floatdrop/pinkie-promise and https://github.com/sindresorhus/pify.
@sindresorhus sindresorhus mentioned this issue Sep 6, 2015
Closed
@vadimdemedes vadimdemedes mentioned this issue Sep 6, 2015
Closed
5 tasks
sindresorhus pushed a commit that referenced this issue Sep 8, 2015
@sindresorhus
Promisification
7357b69 
Close #39 PR
Fixes #38
sindresorhus pushed a commit that referenced this issue Sep 8, 2015
@sindresorhus
Promisification
fa3ca81 
Close #39 PR
Fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement new functionality help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sindresorhus