TAP report prints test titles above not ok message

[will-weiss]

Description

The TAP report prints the failing assertion rather than the title of the test after the not ok message. If I have a test file test.js that reads:

import { test } from 'ava';

test('one should equal two', t => {
  t.is(1, 2);
});

and I run ava --tap, the resulting TAP report looks like this:

TAP version 13
# one should equal two
not ok 1 - 1 === 2
  ---
    operator: ===
    expected: 2
    actual: 1
    at: _callee$ (test.js:4:4)
  ...

1..1
# tests 1
# pass 0
# fail 1

This is an issue because I am using a Jenkins TAP Plugin that reports the titles of the tests incorrectly, as it interprets 1 - 1 === 2 as the name of the test. I would expect the TAP report to look like this:

TAP version 13
# one should equal two
not ok 1 - one should equal two
  ---
    operator: ===
    expected: 2
    actual: 1
    at: _callee$ (test.js:4:4)
  ...

1..1
# tests 1
# pass 0
# fail 1

If this is an issue with a dependency of ava and not with ava itself, please direct me to that project instead and I'll be happy to file an issue there.

Thanks in advance!

Environment

Node.js v5.9.0
darwin 14.5.0

[novemberborn]

Hi @will-weiss thanks for your report. I believe this is a duplicate of #324.

[novemberborn]

Actually I'm not sure now. @jamestalmage?

[jamestalmage]

Yeah - This is a legit issue. Related to #324, but not identical. I have tap-emitter in the works.

help wanted!

[sotojuan]

@jamestalmage For now is it fine to submit a PR that changes

format('not ok %d - %s', ++this.i, test.error.message),

with

format('not ok %d - %s', ++this.i, test.title),

In lib/reporters/tap.js? Seems like that would emit the output @will-weiss wants.

[jamestalmage]

Works for me.