Switch to lodash.isEqual for deep quality check #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Oct 4, 2016
| @@ -131,6 +131,7 @@ | |||
| "last-line-stream": "^1.0.0", | |||
| "lodash.debounce": "^4.0.3", | |||
| "lodash.difference": "^4.3.0", | |||
| "lodash.isequal": "^4.4.0", | |||
| "loud-rejection": "^1.2.0", | |||
| "matcher": "^0.1.1", | |||
| "max-timeout": "^1.0.0", | |||
There was a problem hiding this comment.
You also need to remove the no-so-shallow dependency here.
There was a problem hiding this comment.
Oh, I thought I removed it.
vadimdemedes
force-pushed
the
switch-deep-equal
branch
from
c761a81 to
55fc728
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1055.
lodash.isEqual()fort.deepEqual().not-so-shallowtotest/assert.jsto ensure regression-free migration (no duplicates).