Pass --no-color flag down to the forked process - fixes #843

[thinkimlazy]

Sorry that I accidentally deleted last one.

Also I want to notice that just chalk.enabled = true not working, because functions from lib/colors.js has own enabled property. So we need that loop

Object.keys(colors).forEach(function (key) {
	colors[key].enabled = true;
});

[thinkimlazy]

We don't need arrify because Array.prototype.concat already can concat single values
Array.prototype.concat docs

[thinkimlazy]

This turns on colors no matter what.

[thinkimlazy]

We need to turn on colors no matter what while testing. Also in case that Istanbul turning them off at this condition

[thinkimlazy]

Force to use colors while testing
And get rid of useless arrify

[sindresorhus]

It also needs to pass the --no-color flag down to the forked process. If I add console.log(require('chalk').red('colorzzzz')); in a test file, it will still log colors even with $ ava --no-colors. I would expect that to prevent all colors.

[thinkimlazy]

Colors in test files disabled by default. Without flag

import test from 'ava'
import chalk from 'chalk'

test('no colors here', t => {
    t.false(chalk.enabled); // passes
})

[sindresorhus]

Not for me:

❯ ava

  1 failed

  no colors here

  t.false(chalk.enabled)
                |
                true

    Test.fn (test.js:5:5)
    internal/child_process.js:721:12

[vadimdemedes]

Hey @thinkimlazy, happy holidays! Will you have some free time soon to finish this up?

[thinkimlazy]

@vadimdemedes Hello, I'm quite busy right now so I'm not sure that I can fix this any time soon.

[sindresorhus]

Closing for lack of activity and to free it up for someone else interested in working on this.