Skip to content

Update npm, test Node.js 9, detect package-lock churn in CI #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 28, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ node_modules
coverage
bench/.results
types/generated.d.ts
/package-lock.json.md5
20 changes: 16 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
language: node_js
node_js:
- 9
- 8
- 6
- 4
Expand All @@ -8,6 +9,8 @@ env:
- FRESH_DEPS=true
matrix:
exclude:
- node_js: 9
env: FRESH_DEPS=true
- node_js: 6
env: FRESH_DEPS=true
- node_js: 4
Expand All @@ -16,8 +19,17 @@ cache:
directories:
- $HOME/.npm
before_install:
- npm install --global npm@5.4.2
- npm install --global npm@5.6.0
- npm --version
install:
- if [[ ${FRESH_DEPS} == "true" ]]; then npm install --no-shrinkwrap --prefer-online; else npm install --prefer-offline; fi
after_success: ./node_modules/.bin/codecov --file=./coverage/lcov.info
- md5sum package-lock.json > package-lock.json.md5
install: |
if [[ ${FRESH_DEPS} == "true" ]]; then
npm install --no-shrinkwrap --prefer-online;
else
npm install --prefer-offline;
if ! md5sum --quiet -c package-lock.json.md5; then
echo "package-lock.json was modified unexpectedly. Please rebuild it using npm@$(npm -v) and commit the changes.";
exit 1;
fi
fi
after_success: npx codecov --file=./coverage/lcov.info
5 changes: 4 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,22 @@ configuration:
- LockedDeps
environment:
matrix:
- nodejs_version: 9
- nodejs_version: 8
- nodejs_version: 6
- nodejs_version: 4
matrix:
fast_finish: true
exclude:
- configuration: FreshDeps
nodejs_version: 9
- configuration: FreshDeps
nodejs_version: 6
- configuration: FreshDeps
nodejs_version: 4
install:
- ps: Install-Product node $env:nodejs_version
- npm install --global npm@5.4.2
- npm install --global npm@5.6.0
- npm --version
- git config core.symlinks true
- git reset --hard
Expand Down
2 changes: 2 additions & 0 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ You may find an issue is assigned, or has the [`assigned` label](https://github.

We'd like to fix [`priority` issues](https://github.com/avajs/ava/labels/priority) first. We'd love to see progress on [`low-priority` issues](https://github.com/avajs/ava/labels/low%20priority) too. [`future` issues](https://github.com/avajs/ava/labels/future) are those that we'd like to get to, but not anytime soon. Please check before working on these since we may not yet want to take on the burden of supporting those features.

If you're updating dependencies, please make sure you use [email protected] and commit the updated `package-lock.json` file.

### Hang out in our chat

We have a [chat](https://gitter.im/avajs/ava). Jump in there and lurk, talk to us, and help others.
Expand Down