-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adds .avarc
meta file support.
#1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @jtag05, thanks for the PR. #520 has already been closed as wontfix. Clearly this is a contentious issue but I'd like to see an argument in favor of placing configuration outside of Anyway, #520 is the place for that discussion, though of course the "it's what I'm used to" point has already been made. |
@novemberborn there is a perfectly valid argument in #520 that was recently posted. The package.json file has become a dumping ground for configuration. In large projects it makes it huge and unwieldy. Digging through a giant JSON file is not a pleasant experience and is reminiscent of the Java world's XML configs. My team prefers the dotfiles as it neatly separates each tool's configuration that is easily explorable. It is not just because "we are used to it". Every other tool we use manages to support this trivial feature that we value but AVA. It seems absurd that even in the face of community outcry and the presence of a perfectly fine PR the maintainers here ignore the need. |
@novemberborn I'd like to see an argument against implementing 7 lines of code that has no performance issues. I understand that preferences are exactly that, but rather than taking the stance of "why should we?", as a utility should you not be approaching this from the perspective of "Why not?" as a means of maximizing adoption? I think it's fair to argue that whichever route a developer chooses (meta file or package.json) all configuration should be stored the same way. As I have previously stated in the #520 thread, I was a supporter of |
@@ -9,6 +9,7 @@ const EventEmitter = require('events'); | |||
const meow = require('meow'); | |||
const Promise = require('bluebird'); | |||
const pkgConf = require('pkg-conf'); | |||
const fs = require('pkg-conf'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant require('fs')
here.
To add to what @pho3nixf1re said, I prefer dotfiles because they can easily be added to a .npmignore file. Consumers of my packages don't care about various config choices and don't need to download bloated package.json file. |
@psirenny the latest beta release (tagged |
Simple implementation resolving #520.