Fix Missing Import In bench/run.js #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

novemberborn merged 1 commit into avajs:master from unknown repository

Apr 1, 2018

ghost commented Mar 31, 2018

bench/run.js did not import bluebird but used Promise.each() which resulted in an error.


          Fix Missing Import In bench/run.js

cd10e84

novemberborn merged commit 977cf4f into avajs:master

Member

novemberborn commented Apr 1, 2018

Thanks @clemtrek! Looks like this broke in 3da8603 — which landed over a year ago! Perhaps we should just remove the bench tests 😊

novemberborn mentioned this pull request

Problem running benchmarks #1756

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet