Skip to content

Add support for code in expected t.throws() and t.throwsAsync() t… #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2018
Merged

Add support for code in expected t.throws() and t.throwsAsync() t… #1902

merged 2 commits into from
Aug 14, 2018

Conversation

oantoro
Copy link
Contributor

@oantoro oantoro commented Aug 13, 2018

Fixes #1901

@oantoro oantoro mentioned this pull request Aug 13, 2018
Closed
@sindresorhus
Copy link
Member

Can you also update the TypeScript and Flow type definitions?

https://github.com/avajs/ava/blob/master/index.d.ts
https://github.com/avajs/ava/blob/master/index.js.flow

@oantoro
Copy link
Contributor Author

oantoro commented Aug 13, 2018

Sure @sindresorhus

@novemberborn novemberborn merged commit 7f974cc into avajs:master Aug 14, 2018
@novemberborn
Copy link
Member

Thanks @okyantoro!

@ronen
Copy link
Contributor

ronen commented Aug 14, 2018

Thanks @okyantoro from me too!

@oantoro oantoro deleted the throws-assertion-code-number-support branch August 14, 2018 21:24
@novemberborn novemberborn mentioned this pull request Mar 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why does code need to be a string in the expected parm of t.throws?
4 participants
@oantoro @sindresorhus @novemberborn @ronen