-
Notifications
You must be signed in to change notification settings - Fork 1.4k
extend --match to support hash (generated from unique title) #2197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What problems does this solve? |
3efdf3d
to
3312ec2
Compare
request enhancement (and for other new flag --ignore, --match, --find |
Hi @timoweave, impressive work on the PR! To avoid disappointment though, I'd advise filing an issue with your proposal first before doing all the work. As evidenced by @sindresorhus's question above, I don't think this solves an actual problem. It puts more noise in the reporter output and it's not really easier than using I'm looking forward to other PRs from you though! 😄 (I'm closing this issue for housekeeping purposes, but let's keep the conversation going.) |
@timoweave have a look at https://github.com/avajs/ava/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A"help+wanted" — there'll be more esoteric issues without that label if you want to venture really deep into the weeds. |
Need to prioritize 140 issues...
What are the top 25?
… On Aug 2, 2019, at 12:24 AM, Mark Wubben ***@***.***> wrote:
@timoweave have a look at https://github.com/avajs/ava/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A"help+wanted" — there'll be more esoteric issues without that label if you want to venture really deep into the weeds.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
There's "only" 82 with a help wanted label 😉 https://github.com/avajs/ava/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A"help+wanted" We don't have a priority list as such, but you could use the Funded on IssueHunt labels as a proxy. Bugs tend to be more important to solve than feature requests. Generally speaking I find it's most fun to solve a problem you run into yourself, or add a feature you would see yourself using. You can also have a look at the |
Yeah, it's most fun to solve a problem you run into yourself, or add a feature (but you turn it down last time) you would see yourself using.
… On Aug 5, 2019, at 1:36 AM, Mark Wubben ***@***.***> wrote:
Need to prioritize 140 issues...
There's "only" 82 with a help wanted label 😉 https://github.com/avajs/ava/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A"help+wanted"
We don't have a priority list as such, but you could use the Funded on IssueHunt labels as a proxy. Bugs tend to be more important to solve than feature requests.
Generally speaking I find it's most fun to solve a problem you run into yourself, or add a feature you would see yourself using. You can also have a look at the scope: labels to get a sense of where in the codebase the issue is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
extend --match to support hash key, which is generated from title (which ava ensure title to be unique).
enhancement (how to add label)?