Skip to content

extend --match to support hash (generated from unique title) #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

timoweave
Copy link

@timoweave timoweave commented Jul 25, 2019

extend --match to support hash key, which is generated from title (which ava ensure title to be unique).

Screen Shot 2019-07-25 at 1 42 17 PM

What problems does this solve?

enhancement (how to add label)?

@sindresorhus
Copy link
Member

What problems does this solve?

@timoweave timoweave force-pushed the extend_match_option branch from 3efdf3d to 3312ec2 Compare July 25, 2019 22:50
@timoweave
Copy link
Author

request enhancement (and for other new flag --ignore, --match, --find
(#1472)

@novemberborn
Copy link
Member

Hi @timoweave, impressive work on the PR!

To avoid disappointment though, I'd advise filing an issue with your proposal first before doing all the work. As evidenced by @sindresorhus's question above, I don't think this solves an actual problem. It puts more noise in the reporter output and it's not really easier than using --match or adding .only or .skip modifiers inside your test file.

I'm looking forward to other PRs from you though! 😄

(I'm closing this issue for housekeeping purposes, but let's keep the conversation going.)

@timoweave
Copy link
Author

timoweave commented Aug 1, 2019 via email

@novemberborn
Copy link
Member

@timoweave have a look at https://github.com/avajs/ava/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A"help+wanted" — there'll be more esoteric issues without that label if you want to venture really deep into the weeds.

@timoweave
Copy link
Author

timoweave commented Aug 3, 2019 via email

@novemberborn
Copy link
Member

Need to prioritize 140 issues...

There's "only" 82 with a help wanted label 😉 https://github.com/avajs/ava/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A"help+wanted"

We don't have a priority list as such, but you could use the Funded on IssueHunt labels as a proxy. Bugs tend to be more important to solve than feature requests.

Generally speaking I find it's most fun to solve a problem you run into yourself, or add a feature you would see yourself using. You can also have a look at the scope: labels to get a sense of where in the codebase the issue is.

@timoweave
Copy link
Author

timoweave commented Aug 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants