Skip to content

Merge mini and verbose reporter implementations #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 14, 2020

Conversation

m5x5
Copy link
Contributor

@m5x5 m5x5 commented May 12, 2020

This pull request fixes #2217.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@m5x5 m5x5 marked this pull request as ready for review May 14, 2020 17:58
Copy link
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm glad to see the reporter tests are still happy.

It's good to combine the reporters into a single class, but there's still a lot of repetition in that class. We need to remove that, otherwise there's little point.

I've left some other comments below.

m5x5 and others added 2 commits May 17, 2020 20:23
Copy link
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @Michael55555.

I think there's another round of improvements to make. Mainly, I'd like to get this to a place where there's as few surprises as possible for when we next rewrite the reporters. (Combining the two files helps a lot already, of course!)

@novemberborn
Copy link
Member

Something came up and I haven’t yet had a chance to look at this again.

@novemberborn
Copy link
Member

@Michael55555 I've made a bunch more tweaks. I think it's good to go now.

Besides me having already closed it, I don't think this would have solved #653?

@m5x5
Copy link
Contributor Author

m5x5 commented Jun 13, 2020

@novemberborn Sounds good! Yes, I just revisited the issue, it's indeed not related to this PR. I can't remember why I referenced it.🤔

@novemberborn novemberborn changed the title Consolidate mini and verbose reporter Merge mini and verbose reporter implementations Jun 14, 2020
@novemberborn novemberborn merged commit b3866b6 into avajs:master Jun 14, 2020
@novemberborn
Copy link
Member

Great, thank you @Michael55555!

@m5x5
Copy link
Contributor Author

m5x5 commented Jun 14, 2020

Happy to help @novemberborn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate mini and verbose reporters
2 participants