-
Notifications
You must be signed in to change notification settings - Fork 1.4k
print the first assertion failure of each test, instead of the last. Fixes #121, #220 #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -312,3 +312,33 @@ test('wait for test to end', function (t) { | |||
avaTest.pass(); | |||
}, 1234); | |||
}); | |||
|
|||
test('promise is rejected with the first assertError', function (t) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why promise
is mentioned here. It's not really relevant. Should be more like:
fails with the first assertError
Sem with the below.
@jamestalmage Looks good except for some minor nitpick :) Would you mind adding the assertion failure behavior to the docs so it's explicit how it works? When you reference tickets in the the title, can you do so in the description too? It makes it easier to click through. The issue references in the title aren't clickable. @vdemedes ? |
Errr...
|
Ah yes. I should have mentioned. I added the issue references to the PR description for you here. |
OK, I just followed up on a number of other PR's |
Can you fix the merge conflict? |
Working on that and the documentation. |
1dee1b5
to
e697029
Compare
}); | ||
}); | ||
|
||
test('fails with thrown falsie value', function (t) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor, but for consistency falsie
→ falsy
@jamestalmage You are so productive! :D |
OK, I think that covers it. |
Fixes #121.
Fixes #220.