Skip to content

print the first assertion failure of each test, instead of the last. Fixes #121, #220 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

jamestalmage
Copy link
Contributor

Fixes #121.
Fixes #220.

@@ -312,3 +312,33 @@ test('wait for test to end', function (t) {
avaTest.pass();
}, 1234);
});

test('promise is rejected with the first assertError', function (t) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why promise is mentioned here. It's not really relevant. Should be more like:

fails with the first assertError

Sem with the below.

@sindresorhus
Copy link
Member

@jamestalmage Looks good except for some minor nitpick :) Would you mind adding the assertion failure behavior to the docs so it's explicit how it works?

When you reference tickets in the the title, can you do so in the description too? It makes it easier to click through. The issue references in the title aren't clickable.

@vdemedes ?

@jamestalmage
Copy link
Contributor Author

When you reference tickets in the the title, can you do so in the description too? It makes it easier to click through. The issue references in the title aren't clickable.

Errr...

James Talmage commented 6 hours ago ...

@sindresorhus
Copy link
Member

Errr...

Ah yes. I should have mentioned. I added the issue references to the PR description for you here.

@jamestalmage
Copy link
Contributor Author

OK, I just followed up on a number of other PR's

@sindresorhus
Copy link
Member

Can you fix the merge conflict?

@jamestalmage
Copy link
Contributor Author

Working on that and the documentation.

});
});

test('fails with thrown falsie value', function (t) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super minor, but for consistency falsiefalsy

@sindresorhus
Copy link
Member

@jamestalmage You are so productive! :D

@jamestalmage
Copy link
Contributor Author

OK, I think that covers it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants