print the first assertion failure of each test, instead of the last. Fixes #121, #220#259
print the first assertion failure of each test, instead of the last. Fixes #121, #220#259jamestalmage wants to merge 4 commits intoavajs:masterfrom
Conversation
test/test.js
Outdated
There was a problem hiding this comment.
Not sure why promise is mentioned here. It's not really relevant. Should be more like:
fails with the first assertError
Sem with the below.
|
@jamestalmage Looks good except for some minor nitpick :) Would you mind adding the assertion failure behavior to the docs so it's explicit how it works? When you reference tickets in the the title, can you do so in the description too? It makes it easier to click through. The issue references in the title aren't clickable. @vdemedes ? |
Errr...
|
Ah yes. I should have mentioned. I added the issue references to the PR description for you here. |
|
OK, I just followed up on a number of other PR's |
|
Can you fix the merge conflict? |
|
Working on that and the documentation. |
jamestalmage
force-pushed
the
show-first-assertion
branch
from
1dee1b5 to
e697029
Compare
test/test.js
Outdated
There was a problem hiding this comment.
super minor, but for consistency falsie → falsy
|
@jamestalmage You are so productive! :D |
|
OK, I think that covers it. |
2 participants
Fixes #121.
Fixes #220.