WIP - use istanbul-require-hook#297
Closed
jamestalmage wants to merge 1 commit into
Closed
Conversation
Contributor
|
Two things:
|
Contributor
Author
|
@ariporad - yep, this was an exploratory thing I did when that whole discussion kicked off. I am going to be opposed to integrating pirates in any projects until danez/pirates#5 is resolved. |
Contributor
|
@jamestalmage: Fair. I've just posted an update in that issue, in the interest of now flooding this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just another exploratory PR.
Trying to figure out the best way to accommodate custom preprocessors.
istanbul-require-hookwas mentioned here: istanbuljs/nyc#70.I think it shoes great promise. Especially if altered to include hook combining/chaining with something similar to what was done here istanbuljs/nyc#65
I think we are nearing a real solution. Until a clear winner emerges from the solutions proposed in istanbuljs/nyc#70, I think I will fork
istanbul-require-hookwith some changes specific to what we need.