Repository navigation
Add cleanup and cleanupEach hook pairs - #3492
woahwhattheheck wants to merge 8 commits into
Conversation
|
Current-head handoff for
This remains my original contribution and IssueHunt submission for #928. Claimant and payee: @woahwhattheheck. The issue displays an $82 funded pool; I affirmatively request maintainer review, eligible allocation, and the applicable $82 payout through the existing IssueHunt submission process if this contribution is accepted. This is not an assertion that the PR has been accepted, awarded, invoiced, settled, or paid. |
…[skip ci] Apply the optional comparison sanitizer to expected and actual output for the edge-case fixture only. Preserve user stack locations, diagnostic text and other reporter comparisons. The retained fixture comparison has a focused discriminator receipt; do not dispatch repository-wide suites for this forward.
|
Current head is One focused discriminator used the retained first-party Node24 fixture: the baseline line319-versus318 variation failed, the new comparison passed, and changed error text/user-code locations still failed. No full AVA or TAP suite was rerun. This forward uses My original IssueHunt submission for #928 remains tied to this PR. I am requesting acceptance, the eligible allocation from its displayed $82 funded pool and payment through that existing submission. Please confirm approval and payout timing; no compensation is being waived or second claim created. |
Fixes #928
Add two cleanup helpers using the existing hook-registration mechanism:
test.cleanup()registers the callback before the test file and once again asafter.always.test.cleanupEach()registers it before each test and once again as the finalafter.always, preserving the issue's proposed lifecycle rather than adding an afterEach hook.Validation: reviewed all five changed paths on the exact source at
3cac5dcc7b915019dcbf9b8c45a8c4d5d768b529, five commits ahead and zero behind main at the publication check. Four focused direct checks passed on the exact create-chain module with Node24.19.0: file cleanup before/final-after pairing; beforeEach with one final after hook; serial/skip propagation to both hooks; and independent registration argument arrays. These checks exercise registration semantics only. The full AVA suite, hook-runner lifecycle and TypeScript compilation were not run for this submission.Hosted CI receipt
Workflow run
37427496881on exact head3cac5dcc7b915019dcbf9b8c45a8c4d5d768b529completed with 12 of 14 jobs passing.Passing jobs include Node 22 on Ubuntu/macOS/Windows; Node 24 on macOS/Windows; Node 26 on macOS/Windows; TypeScript 5.9 and 6.0; lint; lockfile install; and no-lock install.
The only failures are the Ubuntu Node 24.12 and Node 26 matrix jobs, each on one TAP golden comparison whose stack-source line shifted in Node's internal
esm/utils: Node 24 reports line 319 where the fixture expects 318; Node 26 reports 355 where it expects 354. Those TAP fixture files are not part of this PR's five-file diff. This receipt therefore records the current hosted matrix without treating those unrelated fixture expectations as a source failure in this change, and it does not claim a fully green CI matrix.IssueHunt Summary
Referenced issues
This pull request has been submitted to: