[WIP] - Refactor Runner #455
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's going to end up cleaner / easier to understand - with better separation of concerns. Also has implications for using domains for logging / error tracking. This is real early stuff. Not ready for serious review. Just wanted you aware of what I was doing |
|
Alright |
|
closing in favor of #466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP refactoring
runner.js. One goal is to support addressable test indexes which could be used implement #421.The
test-collectionclass makes all the test data serializable, so it can be passed to the parent thread yet (I'm not actually doing that yet).Still really early. Just wanted some feedback.