fix(prefer-t-throws): detect try/catch asserting on caught error#360
Closed
Jackyzhangyi wants to merge 1 commit into
Closed
fix(prefer-t-throws): detect try/catch asserting on caught error#360Jackyzhangyi wants to merge 1 commit into
Jackyzhangyi wants to merge 1 commit into
Conversation
Member
|
Thanks but I'm not interested in fully AI generated PRs. It's clear you didn't even look it over after submitting. |
Member
|
I suggest opening an issue instead about how you want the rule extended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends
ava/prefer-t-throwsto also flag a common pattern where a test usestry/catchto capture an error and assert on it, without usingt.fail(). Fixes #156Example currently used:
Preferred:
What changed
Notes
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
prefer-t-throws