Skip to content

Conversation

jfmengels
Copy link
Contributor

Fix option configuration examples : prepend rules with "ava/".

FMI: Do you guys prefer to always add code via PRs, or can/should I push this kind of simple fix directly on master? There's no contribution guidelines for maintainers or anything, so I don't know what you agreed on.

@jamestalmage
Copy link
Contributor

If it's obvious or trivial, you can just push to master. Especially if it's just documentation.

Remember, you can't fix mistakes with a --force push on master (that is a big no-no), you have to push a separate "fixup" or "revert" commit. There are lots of ways something can go wrong (you forgot to run the linter one last time, you forgot to save that new dependency in package.json, you forgot some language feature isn't supported in node 0.10, etc), so I usually prefer to just do a PR, or push to a separate branch on the main repo and verify CI passes before merging.

@novemberborn
Copy link
Member

I like seeing PRs for everything. Helps disseminate knowledge. For the obvious/trivial ones it's fine if you merge them straight away.

@novemberborn
Copy link
Member

There's no contribution guidelines for maintainers or anything, so I don't know what you agreed on.

Would be good to add these!

@jfmengels
Copy link
Contributor Author

I like seeing PRs for everything. Helps disseminate knowledge.

👍

For the obvious/trivial ones it's fine if you merge them straight away.

Also 👍. I'll merge this then.

@jfmengels jfmengels merged commit 232048d into master Apr 3, 2016
@jfmengels jfmengels deleted the fix-configuration-example branch April 3, 2016 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants