Category Product Positions#32
Closed
nhp wants to merge 2 commits intoavstudnitz:masterfrom
nhp:master
Closed
Conversation
Owner
|
Rewriting this huge method will most probably break upwards / downwards compatibility, Thus I won't include this pull request. This should be a fix in the core instead. Why does Magento write methods of +200 lines of code? |
Collaborator
|
Can we make some wiki page or additional readme "Known issues" to avoid this to come up again (and linking to that patch) |
Owner
|
Sure, feel free :-) Wikis are activated. |
Collaborator
Author
|
Added Wiki page. Because it is my first one here on github please check it to ensure it is as you would like it. |
Owner
|
Great, thanks! |
Collaborator
|
Thanks @nhp. I have added a link on the main wiki page and did some minor edits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added category product positions other than hardcoded 1