Fix array to string conversion exception#30
Merged
avstudnitz merged 1 commit intoNov 7, 2022
Conversation
Owner
|
Thank you @therouv! I noticed the same thing today, and fixed similarily, but your solution is slightly better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in #28 introduced a change where the current value and scope value are cast to string. This leads however to the following exception, when using an array-serialized/serialized config field in store configuration:
Exception #0 (Exception): Warning: Array to string conversion in /var/www/html/vendor/avstudnitz/scopehint2/Plugin/ConfigFieldPlugin.php on line 138Since the array values can be structured in multiple ways, I propose to just skip the array values and not generate a scope hint label for such cases. These kind of arrays often contain multiple entries anyways, so displaying changes in a popover is tricky anyways.
Noticed the bug while trying to configure the DHL extension which uses a custom ArraySerialized class. But Magento has those kind of classes in the core as well.