Increasing auto select family attempt timeout #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmarty
approved these changes
Oct 8, 2024
YuvalShAz
approved these changes
Oct 9, 2024
JoeJesse
approved these changes
Oct 11, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing
AutoSelectFamilyAttemptTimeoutin order to prevent timeouts for the dual-stack endpoints that sits far away from the github runner. There is a few customer reports in #170 describing this. I've addedaf-south-1region to the integration tests and simulated the same behavior (roughly 50% executions fails this way). The same behaviour doesn't seem to happen when the timeout is increased (the same advice is given in the nodejs/node#54359).thank you @georgeboc