Skip to content

chore(aft): add self-update command #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jordan-Nelson
Copy link
Member

@Jordan-Nelson Jordan-Nelson commented Aug 9, 2022

Issue #, if available:

Description of changes:

  • Add a self-update command to update aft. Inspired by yarn self-update or flutter upgrade

This just runs dart pub global activate -spath <root>/packages/aft.

Motivation: I always forget what the command is to activate a package from a path and have to look it up each time I switch to a branch with new aft changes. This makes it a little easier.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner August 9, 2022 19:34
Copy link
Contributor

@dnys1 dnys1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #2022 (37e5b49) into next (aeef003) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #2022   +/-   ##
=======================================
  Coverage   43.92%   43.92%           
=======================================
  Files         122      122           
  Lines        7549     7549           
=======================================
  Hits         3316     3316           
  Misses       4233     4233           
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 26.64% <ø> (ø)
ios-unit-tests 89.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

import 'package:aft/aft.dart';

/// A command to update the aft package.
class SelfUpdateCommand extends AmplifyCommand {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again - since the version committed in next will always be the "latest"/stable should we expose that as an option or as the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants