fix(auth): SessionExpired Auth Hub event #2609
Conversation
| hubEvent = AuthHubEvent.sessionExpired(); | ||
| if (state is FetchAuthSessionSuccess) { | ||
| final exception = state.session.userPoolTokensResult.exception; | ||
| // TODO(Jordan-Nelson): Update list of exceptions once FetchAuthSession |
There was a problem hiding this comment.
Currently, an AuthNotAuthorizedException is thrown for an expired session, but it should be SessionExpiredException. This has always been the case in next and I have a task to update this.
UnauthorizedException was in the list previously, so I left it for now. I'll look into what scenarios what is thrown in to see if this needs to be included when I take care of the task mentioned above.
|
|
||
| test('should add a sessionExpired event to Auth Hub', () async { | ||
| final authStream = Amplify.Hub.availableStreams[HubChannel.Auth]; | ||
| plugin.fetchAuthSession().ignore(); |
There was a problem hiding this comment.
This might fail on DDC - it doesn't like .ignore in tests for some reason (maybe due to #50619 in the Dart repo). Alternative is the same but more verbose:
unawaited(
plugin.fetchAuthSession().then((_) {}).onError((_, __) {}),
);There was a problem hiding this comment.
They seem to be passing (at least on firefox, looks like they are not running on Chrome) so I will leave for now. If it causes an issue we can change it.
Issue #, if available:
Description of changes:
Fixes a regression introduced by #2585. When refreshing user pool tokens fail due to an expired refresh token, a hub event for Session Expired should be emitted.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.