chore(auth): Remove package:oauth2 dependency
#3119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum lift-and-shift required to remove `package:oauth2` and by extension, `package:http`, dependency.
dnys1
force-pushed
the
fix/remove-oauth2-dep
branch
from
5f0c615 to
ef7751d
Compare
dnys1
force-pushed
the
fix/remove-oauth2-dep
branch
from
b8672c2 to
8ab2720
Compare
Due to changes in #3099
Equartey
approved these changes
May 31, 2023
There was a problem hiding this comment.
Should we also fork the unit tests for these files? I'm fine not taking them if you think our tests are sufficient.
|
|
|
Thanks for the heads up, @Albert221. Closing in favor of #3132. Will reopen when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dart authors are deprecating
package:oauth2(dart-lang/tools#375). This means we can likely not expect to receive further updates. Currently, theirpackage:httpconstraint doesn't allow the latest version (1.0.0) and this is the only package we use which bringshttpinto our dependency tree.Rather than force our customers to work around this, this PR has the minimum lift-and-shift required to remove
package:oauth2and by extension,package:http, dependency. It does this by copying over the subset ofpackage:oauth2we use and updating it to useAWSHttpClientinstead.Accuracy verified through CI and local e2e tests for all platforms.