Update datastore error handling for android + flutter as per #314 #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amplify_core_refactor
Amplifiyer
changed the title
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 69.75% 69.85% +0.10%
==========================================
Files 232 230 -2
Lines 6858 6775 -83
Branches 319 315 -4
==========================================
- Hits 4784 4733 -51
+ Misses 1953 1924 -29
+ Partials 121 118 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
haverchuck
reviewed
Jan 30, 2021
...re/android/src/main/kotlin/com/amazonaws/amplify/amplify_datastore/AmplifyDataStorePlugin.kt
Outdated
Show resolved
Hide resolved
haverchuck
approved these changes
Jan 30, 2021
fjnoyp
reviewed
Feb 1, 2021
packages/amplify_datastore_plugin_interface/lib/src/types/exception/DataStoreException.dart
Show resolved
Hide resolved
packages/amplify_datastore/ios/Classes/FlutterDataStoreErrorHandler.swift
Show resolved
Hide resolved
packages/amplify_datastore/ios/Classes/FlutterDataStoreErrorHandler.swift
Show resolved
Hide resolved
| @@ -94,7 +94,7 @@ public class SwiftAmplifyDataStorePlugin: NSObject, FlutterPlugin { | |||
| modelSchemas.forEach { (modelSchema) in | |||
| flutterModelRegistration.addModelSchema(modelName: modelSchema.name, modelSchema: modelSchema) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Should we add an error for lines 83 above. It just says return //TODO
There was a problem hiding this comment.
I'm not sure what should be the right error message be in this case by quickly looking at it. Can you provide one or is this a generic unknown exception?
There was a problem hiding this comment.
This looks to be a generic unknown exception when the map passed from Dart is not correct.
There was a problem hiding this comment.
This is really minor, so I'll approve now.
packages/amplify_datastore/ios/Classes/SwiftAmplifyDataStorePlugin.swift
Show resolved
Hide resolved
fjnoyp
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Update error handling for android + flutter as per #314
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.