fix(Datastore) : Use throwing iterator to avoid hidden force try

[ashiemke]

Issue #, if available: None

Description of changes: Using the default iterator on a statement uses a force try, which crashes (although I'm not sure the circumstances). Replace that with a long-form while rather than for-in to re-throw exception rather than crashing.

See stephencelis/SQLite.swift#1030 for discussion

Check points:

- [ ] Added new tests to cover change, if needed

• All unit tests pass
• All integration tests pass
  - [ ] Documentation update for the change if required
• PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[thisisabhash]

Hello, Could you please add information about when a situation would arise that'd cause a crash and possible ways to test it?

[ChadyG]

@thisisabhash Sorry for the delay. I have a test that will usually generate this crash.

This can occur when calling DataStore.clear() during an initial sync after login. Our app calls clear on Auth signedOut events, so this pops up every so often. We have a test that logs in and back out a handful of times that will usually cause this crash to occur.

[ChadyG]

@thisisabhash Any word on when this might get merged or updated?

[thisisabhash]

Existing unit tests and integration tests are passing with the changes. LGTM.

[thisisabhash]

SQLite codebase uses a force try in default iterator which causes a crash.
I tried to reproduce by calling Datastore.clear() on Auth signedOut events but couldn't reproduce.
Merging this in because it is difficult to replicate the crash in an integration test having a clear use case.
A unit test to cover the change is difficult as it is difficult to mock Statement and Connection classes because they are marked final and part of SQLite codebase.

Verified that existing integration tests and unit tests are passing for this PR.