Sort querystring prior to signing#62
Merged
jkakar merged 1 commit intoaws-beam:masterfrom Jan 26, 2022
onno-vos-dev:sort-query-string-before-signing
Merged
Sort querystring prior to signing#62jkakar merged 1 commit intoaws-beam:masterfrom onno-vos-dev:sort-query-string-before-signing
jkakar merged 1 commit intoaws-beam:masterfrom
onno-vos-dev:sort-query-string-before-signing
Conversation
andreashasse
approved these changes
Jan 26, 2022
onno-vos-dev
commented
Jan 26, 2022
| %% URL and query string as separate values. | ||
| split_url(URL) -> | ||
| URI = hackney_url:parse_url(URL), | ||
| %% FIXME(jkakar) Query string name/value pairs should be URL encoded |
Member
Author
There was a problem hiding this comment.
This FIXME is what bit us in the end.
enidgjoleka
approved these changes
Jan 26, 2022
jkakar
approved these changes
Jan 26, 2022
| %% URL and query string as separate values. | ||
| split_url(URL) -> | ||
| URI = hackney_url:parse_url(URL), | ||
| %% FIXME(jkakar) Query string name/value pairs should be URL encoded |
Member
Author
|
@jkakar I lack merge rights, any chance you can merge it for me? 😊 |
Member
Author
|
Thank you @jkakar <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, multipart uploading is still broken. This was not caught in previous tests as s3mock from Adobe apparently allows our request to go through without sorted querystring upon signing. In our staging and production system we only tested the
create_multipartpart of the multipart uploading flow without going all the way to the end.Added a test that verifies that querystring must always be sorted.