http_uri:encode/1 does not handle paths containing () which the encoding from aws-signature does#73
Merged
philss merged 1 commit intoaws-beam:masterfrom Feb 13, 2022
onno-vos-dev:fix-encoding-of-special-chars-better-than-http_uri-encode
Merged
http_uri:encode/1 does not handle paths containing () which the encoding from aws-signature does#73philss merged 1 commit intoaws-beam:masterfrom onno-vos-dev:fix-encoding-of-special-chars-better-than-http_uri-encode
philss merged 1 commit intoaws-beam:masterfrom
onno-vos-dev:fix-encoding-of-special-chars-better-than-http_uri-encode
Conversation
…ing from aws-signature does - Use encoding as defined in aws_sgignature_utils:uri_encode_path/1
danfilip
approved these changes
Feb 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tricky one since s3mock does not fail the request with
SignatureDoesNotMatcherror while AWS itself does fail. (Will file a bug report there)The encoding has been taken straight from: aws_signature_utils.erl#L93 which I intend to work on as part of #63 which would have prevented this bug from happening 😞
Before this change a request as below will lead to
SignatureDoesNotMatcherror, after it won't and files can be written, read, listed and deleted as per usual.