Add --role-arn option for deploy sub command. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stilvoid
requested changes
Mar 30, 2022
internal/aws/cfn/cfn.go
Outdated
| @@ -192,6 +192,10 @@ func CreateChangeSet(template cft.Template, params []types.Parameter, tags map[s | |||
| }, | |||
| } | |||
|
|
|||
| if roleArn != "" { | |||
| input.RoleARN = &roleArn | |||
There was a problem hiding this comment.
Should use ptr.String here to wrap the string
There was a problem hiding this comment.
Thank you for the feedback! I modified it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #71
Description of changes: Add
--role-arnoption for deploy sub command to set service role.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.