-
Notifications
You must be signed in to change notification settings - Fork 12
Implement Integration resource #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @cPu1. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
08d642f
to
97c297e
Compare
/ok-to-test |
/retest |
97c297e
to
79505cb
Compare
6d53d4f
to
30379dd
Compare
/retest |
Signed-off-by: cpu1 <[email protected]>
30379dd
to
a5d2326
Compare
apis/v1alpha1/integration.go
Outdated
// Specifies a put integration input's type. | ||
// +kubebuilder:validation:Required | ||
Type *string `json:"type_"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can override this tag to json:"type"
using something like https://github.com/aws-controllers-k8s/eks-controller/blob/main/generator.yaml#L445-L446
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I was looking for this feature but could not find it in code-generator. I saw another controller using the type_
field as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, this change also ended up removing type_
from the required field list. It's a bug in code-generator.
Signed-off-by: cpu1 <[email protected]>
@cPu1: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, cPu1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: aws-controllers-k8s/community#1126 Description of changes: Implements support for creating `Stage` resources in API Gateway. This is based off the `cPu1:resource/integration` branch and must be reviewed after merging #10. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: aws-controllers-k8s/community#1126
Description of changes:
Implements support for creating
Integration
resources in API Gateway.This is based off the
cPu1:resource/resource
branch and must be reviewed after merging #9.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.