Skip to content

Implement Integration resource #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Aug 28, 2024

Issue #, if available: aws-controllers-k8s/community#1126

Description of changes:

Implements support for creating Integration resources in API Gateway.

This is based off the cPu1:resource/resource branch and must be reviewed after merging #9.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from a-hilaly August 28, 2024 09:28
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 28, 2024
Copy link

ack-prow bot commented Aug 28, 2024

Hi @cPu1. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cPu1 cPu1 force-pushed the resource/integration branch 3 times, most recently from 08d642f to 97c297e Compare August 28, 2024 09:33
@cPu1 cPu1 mentioned this pull request Aug 28, 2024
@a-hilaly
Copy link
Member

a-hilaly commented Sep 4, 2024

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2024
@a-hilaly
Copy link
Member

a-hilaly commented Sep 4, 2024

/retest

@cPu1 cPu1 force-pushed the resource/integration branch from 97c297e to 79505cb Compare September 4, 2024 14:20
@cPu1 cPu1 force-pushed the resource/integration branch 3 times, most recently from 6d53d4f to 30379dd Compare October 1, 2024 14:42
@cPu1
Copy link
Contributor Author

cPu1 commented Oct 1, 2024

/retest

@cPu1 cPu1 force-pushed the resource/integration branch from 30379dd to a5d2326 Compare October 1, 2024 22:54
Comment on lines 88 to 90
// Specifies a put integration input's type.
// +kubebuilder:validation:Required
Type *string `json:"type_"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was looking for this feature but could not find it in code-generator. I saw another controller using the type_ field as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, this change also ended up removing type_ from the required field list. It's a bug in code-generator.

Copy link

ack-prow bot commented Oct 1, 2024

@cPu1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
apigateway-verify-attribution 3c2816f link false /test apigateway-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
Copy link

ack-prow bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, cPu1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Oct 1, 2024
@ack-prow ack-prow bot merged commit f9fa8de into aws-controllers-k8s:main Oct 1, 2024
6 of 7 checks passed
ack-prow bot pushed a commit that referenced this pull request Oct 1, 2024
Issue #, if available: aws-controllers-k8s/community#1126

Description of changes:

Implements support for creating `Stage` resources in API Gateway.

This is based off the `cPu1:resource/integration` branch and must be reviewed after merging #10. 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants