Skip to content

Add support for api_key resource #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 10, 2025
Merged

Add support for api_key resource #29

merged 7 commits into from
Apr 10, 2025

Conversation

rushmash91
Copy link
Member

@rushmash91 rushmash91 commented Mar 31, 2025 •
edited
Loading

Description of changes:

  • Adding support for Api keys resource
  • Tests
  • Value is a secret reference
  • Tags Support

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm March 31, 2025 16:42
@ack-prow ack-prow bot added the approved label Mar 31, 2025
@rushmash91
Copy link
Member Author

/restest

a-hilaly
a-hilaly reviewed Apr 1, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rushmash91 ! This LGTM overall~

@rushmash91 rushmash91 force-pushed the apikey branch 3 times, most recently from 84eb475 to 9cf9356 Compare April 2, 2025 03:49
@rushmash91
Copy link
Member Author

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2025
@rushmash91 rushmash91 force-pushed the apikey branch 2 times, most recently from ad02ca0 to 6fc2087 Compare April 9, 2025 16:20
@rushmash91
Copy link
Member Author

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2025
@rushmash91 rushmash91 force-pushed the apikey branch 4 times, most recently from e168038 to a1f5007 Compare April 9, 2025 18:44
@a-hilaly
Copy link
Member

a-hilaly commented Apr 9, 2025

/retest

michaelhtm
michaelhtm reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rushmash91 👍
left a few comments

@rushmash91 rushmash91 force-pushed the apikey branch 7 times, most recently from 3c9e70a to d85fa84 Compare April 10, 2025 06:26
michaelhtm
michaelhtm reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more inline comments..

a-hilaly
a-hilaly reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arush!

pkg/resource/api_key/hooks.go
key := fmt.Sprintf("%s/%s", *sk.RestAPIID, *sk.StageName)
if !desiredMap[key] {
encodedKey := strings.Replace(key, "/", "~1", -1)
patchSet.Remove(fmt.Sprintf("/stages/%s", encodedKey))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if it's not gonna complicate the code, can we just avoid adding it in L88?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned it up a bit if that what you were referring to?

@rushmash91 rushmash91 force-pushed the apikey branch 2 times, most recently from 1a68932 to e5fec5d Compare April 10, 2025 18:54
@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 10, 2025

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
apigateway-verify-attribution 2cf60ac link false /test apigateway-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

a-hilaly
a-hilaly approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

michaelhtm
michaelhtm approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce 💯
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 0a1f75d into aws-controllers-k8s:main Apr 10, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@michaelhtm michaelhtm michaelhtm approved these changes

Assignees

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushmash91 @a-hilaly @michaelhtm