Skip to content

add support for APIMethodResponse #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

add support for APIMethodResponse #32

merged 2 commits into from
Apr 8, 2025

Conversation

rushmash91
Copy link
Member

Description of changes:

  • add support for Method Response Resource

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm April 3, 2025 16:27
@ack-prow ack-prow bot added the approved label Apr 3, 2025
a-hilaly
a-hilaly reviewed Apr 3, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rushmash91 !

michaelhtm
michaelhtm reviewed Apr 3, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rushmash91

@rushmash91
Copy link
Member Author

/retest

@rushmash91 rushmash91 force-pushed the method-response branch 12 times, most recently from b80ed32 to 691176d Compare April 4, 2025 19:47
@rushmash91
Copy link
Member Author

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2025
@michaelhtm michaelhtm changed the title add support for Method response add support for ApiMethodResponse Apr 7, 2025
@rushmash91
Copy link
Member Author

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2025
a-hilaly
a-hilaly reviewed Apr 8, 2025
View reviewed changes
@rushmash91 rushmash91 force-pushed the method-response branch 2 times, most recently from b506cb5 to af198d7 Compare April 8, 2025 00:19
a-hilaly
a-hilaly approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/cc @michaelhtm

@ack-prow ack-prow bot requested a review from michaelhtm April 8, 2025 00:39
@rushmash91
Copy link
Member Author

/retest

@rushmash91 rushmash91 force-pushed the method-response branch 3 times, most recently from 726eb50 to 106a820 Compare April 8, 2025 03:30
@rushmash91
Copy link
Member Author

/retest

1 similar comment
@rushmash91
Copy link
Member Author

/retest

@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 8, 2025 •
edited
Loading

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
apigateway-verify-attribution aa510f8 link false /test apigateway-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

michaelhtm
michaelhtm approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelhtm
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit a7ee505 into aws-controllers-k8s:main Apr 8, 2025
6 of 7 checks passed
@rushmash91 rushmash91 changed the title add support for ApiMethodResponse add support for APIMethodResponse Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@michaelhtm michaelhtm michaelhtm approved these changes

Assignees

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushmash91 @michaelhtm @a-hilaly