-
Notifications
You must be signed in to change notification settings - Fork 12
Add deployment
resource support
#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment
resource support
#36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @rushmash91 🚀🚀🚀
left few nits
d1aadd7
to
e51a6a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rushmash91 👍
left a few inline comments
apis/v1alpha1/generator.yaml
Outdated
exceptions: | ||
terminal_codes: | ||
- BadRequestException | ||
- UnauthorizedException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this truly terminal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
Unauthorized requires - Fixing authorizer config, pass token, check headers..
BadRequest - fix dependencies for deployment in the api
e51a6a3
to
e4886e0
Compare
@rushmash91: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
🚀🚀🚀🚀 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
adding support for deployment resource in apigateway
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.