Skip to content

add authorizer resource support #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

add authorizer resource support #37

merged 3 commits into from
Apr 28, 2025

Conversation

rushmash91
Copy link
Member

Description of changes:
Add support for authorizer resource

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm April 27, 2025 19:54
@ack-prow ack-prow bot added the approved label Apr 27, 2025
@rushmash91 rushmash91 force-pushed the authorizer branch 2 times, most recently from ce92e74 to 15f42eb Compare April 27, 2025 20:41
a-hilaly
a-hilaly reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! left a few tiny comments below:

@rushmash91 rushmash91 force-pushed the authorizer branch 4 times, most recently from 903077f to 18f38cd Compare April 28, 2025 21:02
@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 28, 2025

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
apigateway-verify-attribution 976d655 link false /test apigateway-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

a-hilaly
a-hilaly reviewed Apr 28, 2025
View reviewed changes
apis/v1alpha1/authorizer.go
// function using incoming request parameters, and COGNITO_USER_POOLS for using
// an Amazon Cognito user pool.
// +kubebuilder:validation:Required
Type *string `json:"type,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

a-hilaly
a-hilaly approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean! thank you sir!
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 79b8b58 into aws-controllers-k8s:main Apr 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@michaelhtm michaelhtm Awaiting requested review from michaelhtm

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rushmash91 @a-hilaly