Support custom nested fields that have path that contains types other than struct #538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Say we want to overwrite a nested field type e.g. for
WAFv2
controller (this is needed due to a cyclic dependency):Currently, the overwrite code logic does not work for the above scenario and it returns the following error:
This happens because
Rules
is not of typestruct
, but[]struct
, and the referenced code logic requires that all fields within the path (i.e.Rules
andStatement
to be of typestruct
).This PR relaxes the logic to allow fields within the path to also be of types
[]struct
andmap[]struct
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.