feat: Add watch selector support to controller manager #575
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a-hilaly
force-pushed
the
watch-selectors
branch
2 times, most recently
from
3b3dda6 to
aed3ea7
Compare
Adds the configured watch selectors to the controller managers cache options, allowing filtered resource watching based on labels. Co-authored-by: itaiatu <[email protected]>
a-hilaly
force-pushed
the
watch-selectors
branch
from
aed3ea7 to
00ed5f5
Compare
| @@ -57,6 +57,8 @@ spec: | |||
| - "$(ACK_RESOURCE_TAGS)" | |||
| - --watch-namespace | |||
| - "$(ACK_WATCH_NAMESPACE)" | |||
| - --watch-selectors | |||
| - "$(ACK_WATCH_SELECTORS)" | |||
| - --deletion-policy | |||
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/test ec2-controller-test |
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Adds the configured watch selectors to the controller managers cache options, allowing
filtered resource watching based on labels.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.