-
Notifications
You must be signed in to change notification settings - Fork 206
Fix unkeyed struct literals in metav1.Time
references warnings
#592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… unkeyed fields warnings
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch @rushmash91 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @rushmash91 ! question, are the warnings produced by the compiler (as in go build
) or gofmt?
@a-hilaly |
/retest |
/test ec2-controller-test |
1 similar comment
/test ec2-controller-test |
@rushmash91: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, knottnt, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why? I don't understand how the screenshot proofs that it's the compiler Cc @rushmash91 |
Description of changes:
fixes compiler warnings related to unkeyed field initialization in metav1.Time struct literals throughout the codebase. Updated all instances to explicitly specify the Time field when initializing metav1.Time structs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.