Skip to content

Fix unkeyed struct literals in metav1.Time references warnings #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rushmash91
Copy link
Member

Description of changes:

fixes compiler warnings related to unkeyed field initialization in metav1.Time struct literals throughout the codebase. Updated all instances to explicitly specify the Time field when initializing metav1.Time structs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and knottnt May 14, 2025 20:20
@ack-prow ack-prow bot added the approved label May 14, 2025
@rushmash91
Copy link
Member Author

/retest

Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @rushmash91 👍

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @rushmash91 ! question, are the warnings produced by the compiler (as in go build) or gofmt?

@rushmash91
Copy link
Member Author

are the warnings produced by the compiler (as in go build) or gofmt?

@a-hilaly go build compiler

eg:
Screenshot 2025-05-15 at 12 10 41 AM

@rushmash91
Copy link
Member Author

/retest

@rushmash91
Copy link
Member Author

/test ec2-controller-test

1 similar comment
@rushmash91
Copy link
Member Author

/test ec2-controller-test

Copy link

ack-prow bot commented May 15, 2025

@rushmash91: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution f7f07fd link false /test verify-attribution
s3-olm-test f7f07fd link false /test s3-olm-test
ec2-controller-test f7f07fd link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ack-prow bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,knottnt,michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member

a-hilaly commented May 16, 2025

go build compiler

Why? I don't understand how the screenshot proofs that it's the compiler

Cc @rushmash91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants