Skip to content

Don't match Status field when nil in ReadMany operation #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knottnt
Copy link
Contributor

@knottnt knottnt commented Jul 8, 2025

Issue #, if available:

Description of changes:

  • Update generated matching field check to fail on nil Status fields
  • Add test to verify generated output structure.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Update generated matching field check to fail on nil Status fields

- Add test to verify generated output structure.
@ack-prow ack-prow bot requested review from michaelhtm and rushmash91 July 8, 2025 16:36
@ack-prow ack-prow bot added the approved label Jul 8, 2025
Copy link

ack-prow bot commented Jul 8, 2025

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 580a56e link false /test verify-attribution
s3-olm-test 580a56e link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope for this PR, but something i wish set_resource did is evaluate "continuing/breaking" conditions the first. e.g

if name != x {
  continue
}
if status.something != y {
  continue
}
// we matched let's set the fields
...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah having the matching field checks act as a guard clause would be more readable.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks @knottnt !

Copy link

ack-prow bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants