Skip to content

Make Config and Secretes Required for OpenShift Deployments #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acornett21 opened this issue Nov 1, 2021 · 1 comment · Fixed by aws-controllers-k8s/code-generator#235
Assignees
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.

Comments

@acornett21
Copy link
Contributor

Is your feature request related to a problem?
I'm frustrated when I forget to configure a new cluster with proper Config/Secretes for a controller to run properly and have to wait for a crashback loop to figure out the issue.

Describe the solution you'd like
I would like OpenShift to not fully provision a pod when, so when a cluster admin looks at the pod, or at events the error as to why a given controller isn't starting is clear. IE
for a pod the below would be displayed. Then the cluster admin can go to events and see what is not configured properly.
STATUS: CreateContainerConfigError

Describe alternatives you've considered
Update the deployment template to have optional: false for both the config map and secrets.

@acornett21 acornett21 added the kind/enhancement Categorizes issue or PR as related to existing feature enhancements. label Nov 1, 2021
@acornett21
Copy link
Contributor Author

/assign

ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this issue Nov 1, 2021
…t template (#235)

Issue #, if available:
Fixes: aws-controllers-k8s/community#1052

Description of changes:
Update to make `ack-user-config` and `ack-user-secrets` in the deployment be required for OpenShift. Thus making the operator installation fail false with clearer errors for the cluster admin.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Signed-off-by: Adam D. Cornett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.
Projects
None yet
1 participant