Skip to content

[Resource-Relationship] Implement referencing resource(s) from another api-group #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vijtrip2 opened this issue Dec 9, 2021 · 0 comments
Closed

[Resource-Relationship] Implement referencing resource(s) from another api-group #1091

vijtrip2 opened this issue Dec 9, 2021 · 0 comments
Assignees
@vijtrip2
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.
Milestone
ACK Core (2021-02...

Comments

@vijtrip2
Copy link
Contributor

vijtrip2 commented Dec 9, 2021 •
edited
Loading

[Resource-Relationship] Implement referencing resource(s) from another api-group
Parent issue: #545
@vijtrip2 vijtrip2 self-assigned this Dec 9, 2021
@vijtrip2 vijtrip2 mentioned this issue Dec 9, 2021
Merged
@jaypipes jaypipes added the kind/enhancement Categorizes issue or PR as related to existing feature enhancements. label Jan 14, 2022
@vijtrip2 vijtrip2 mentioned this issue Feb 10, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this issue Feb 22, 2022
@vijtrip2
allow resource references across service controllers (#288)
386dc0d 
Issue #, if available: aws-controllers-k8s/community#1091

Description of changes:
* aws-controllers-k8s/community#1092
* Adds a new `ServiceName` parameter in `ReferencesConfig` to indicate when the referenced resource is from another service controller
* Based on the `ServiceName` parameter imports the API-types from that service controller
* Adds the additional RBAC permissions to allow reading the referenced resource from another service controller

Tested by generating and running apigatewayv2-controller which refers the Subnet and SecurityGroup resource from ec2 controller. Please see the [proposal link](aws-controllers-k8s/community#1092) for generated code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot pushed a commit that referenced this issue Feb 24, 2022
@vijtrip2
proposal for referencing resource from another service controller (#1092
35c82d5 
)

Issue #, if available: #1091

Description of changes:

* Proposal for supporting resource references from other service controllers i.e. different api-groups

See the rendered doc [here](https://github.com/vijtrip2/community/blob/xapigroup/docs/design/proposals/resource-reference/cross-api-group.md) 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vijtrip2 vijtrip2

Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.
Projects
None yet
Milestone
ACK Core (2021-02-14 thru 2022-02-25)
Development

No branches or pull requests
3 participants
@jaypipes @a-hilaly @vijtrip2