Support kustomize for S3 #350
Conversation
|
We're going to need to use a specific version of |
| kind: CustomResourceDefinition | ||
| metadata: | ||
| annotations: | ||
| controller-gen.kubebuilder.io/version: v0.3.1-0.20200716001835-4a903ddb7005 | ||
| controller-gen.kubebuilder.io/version: v0.4.0 |
There was a problem hiding this comment.
@jaypipes Do you think it is enough if annotated here?
There was a problem hiding this comment.
It's not really about the annotation (that is created by the controller-gen crd command). It's that we need to fix ALL the controllers, not just S3 :)
And the root of the fix is in how we install a specific version of controller-gen. We're currently using go get which has the very unfortunate side-effect of modifying the go.mod and go.sum file for the source repository, which isn't what we want.
I'll take a stab at trying to fix this in a less instrusive way, @ricardo-larosa.
There was a problem hiding this comment.
Cool! For reference kubernetes-sigs/kubebuilder#1351
|
@ricardo-larosa I think we're good to close this PR out, yeah? All service controllers have now been updated for controller-gen 0.4.0 and we've ensured in our build scripts that [email protected] is installed. |
|
thanks @jaypipes |
Make possible to install ACK S3 via Kustomize and also fix #349
Run:
Please note it uses latest