Skip to content

Add Route to RouteTable using ACK runtime v0.15.2 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 18, 2021
Merged

Add Route to RouteTable using ACK runtime v0.15.2 #21

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a1ded32
RouteTable move Routes from Status to Spec
brycahta Nov 8, 2021
63f6c23
add hooks for Route
brycahta Nov 15, 2021
f877b68
fix creating RouteTable with Routes
brycahta Nov 15, 2021
7de88b1
add crud test for route
brycahta Nov 15, 2021
45bcf45
add terminal condition for attempting to delete default route and test
brycahta Nov 16, 2021
c43e349
cleanup route table hook code
brycahta Nov 16, 2021
bd6c24b
fix cidr block in subnet test
brycahta Nov 16, 2021
1da6376
dynamically generate compareRoute
brycahta Nov 16, 2021
b870365
refactor syncRoutes
brycahta Nov 16, 2021
8e6dff5
update cidr block in RouteTable tests
brycahta Nov 16, 2021
c62f8ff
fix matchRoute logic
brycahta Nov 16, 2021
c90642e
add Routes to Status
brycahta Nov 17, 2021
2c73566
update hook logic to populate RouteStatuses and fix test
brycahta Nov 17, 2021
0863ab7
Generate create, delete and setter for Route
Nov 18, 2021
b23c5f3
Merge pull request #1 from RedbackThomson/route-or-route
brycahta Nov 18, 2021
0117e4c
add Route comments to generator.yaml
brycahta Nov 18, 2021
3fbe7a3
Remove RouteTableId from Route Spec
brycahta Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2021-11-08T20:16:44Z"
build_date: "2021-11-16T19:16:05Z"
build_hash: 6ce1a672eabd3908bdaa4ace356e1b58ee3e80ba
go_version: go1.17
version: v0.15.2
api_directory_checksum: 231335e65c729f31ac368b1483a38c2964b3219a
api_directory_checksum: 1eb52a5e544da8ce7e0a002e605254e4501296b2
api_version: v1alpha1
aws_sdk_go_version: v1.37.10
generator_config_info:
file_checksum: 438c2600566029a9ab883076d641246f0a8fbb88
file_checksum: acb593a25988c80f7edc78127b9d8e859236809d
original_file_name: generator.yaml
last_modification:
reason: API generation
12 changes: 12 additions & 0 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,18 @@ resources:
terminal_codes:
- InvalidVpcID.Malformed
- InvalidVpcID.NotFound
- InvalidParameterValue
fields:
Routes:
custom_field:
list_of: Route
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So clean ❤️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fresh.

hooks:
sdk_create_post_set_output:
template_path: hooks/route_table/sdk_create_post_set_output.go.tpl
sdk_file_end:
template_path: hooks/route_table/sdk_file_end.go.tpl
update_operation:
custom_method_name: customUpdateRouteTable
SecurityGroup:
fields:
# support EC2-VPC only
Expand Down
4 changes: 1 addition & 3 deletions apis/v1alpha1/route_table.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions apis/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

73 changes: 36 additions & 37 deletions config/crd/bases/ec2.services.k8s.aws_routetables.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,42 @@ spec:
description: "RouteTableSpec defines the desired state of RouteTable.
\n Describes a route table."
properties:
routes:
items:
description: Describes a route in a route table.
properties:
carrierGatewayID:
type: string
destinationCIDRBlock:
type: string
destinationIPv6CIDRBlock:
type: string
destinationPrefixListID:
type: string
egressOnlyInternetGatewayID:
type: string
gatewayID:
type: string
instanceID:
type: string
instanceOwnerID:
type: string
localGatewayID:
type: string
natGatewayID:
type: string
networkInterfaceID:
type: string
origin:
type: string
state:
type: string
transitGatewayID:
type: string
vpcPeeringConnectionID:
type: string
type: object
type: array
tagSpecifications:
description: The tags to assign to the route table.
items:
Expand Down Expand Up @@ -165,43 +201,6 @@ spec:
routeTableID:
description: The ID of the route table.
type: string
routes:
description: The routes in the route table.
items:
description: Describes a route in a route table.
properties:
carrierGatewayID:
type: string
destinationCIDRBlock:
type: string
destinationIPv6CIDRBlock:
type: string
destinationPrefixListID:
type: string
egressOnlyInternetGatewayID:
type: string
gatewayID:
type: string
instanceID:
type: string
instanceOwnerID:
type: string
localGatewayID:
type: string
natGatewayID:
type: string
networkInterfaceID:
type: string
origin:
type: string
state:
type: string
transitGatewayID:
type: string
vpcPeeringConnectionID:
type: string
type: object
type: array
tags:
description: Any tags assigned to the route table.
items:
Expand Down
12 changes: 12 additions & 0 deletions generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,18 @@ resources:
terminal_codes:
- InvalidVpcID.Malformed
- InvalidVpcID.NotFound
- InvalidParameterValue
fields:
Routes:
custom_field:
list_of: Route
hooks:
sdk_create_post_set_output:
template_path: hooks/route_table/sdk_create_post_set_output.go.tpl
sdk_file_end:
template_path: hooks/route_table/sdk_file_end.go.tpl
update_operation:
custom_method_name: customUpdateRouteTable
SecurityGroup:
fields:
# support EC2-VPC only
Expand Down
73 changes: 36 additions & 37 deletions helm/crds/ec2.services.k8s.aws_routetables.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,42 @@ spec:
description: "RouteTableSpec defines the desired state of RouteTable.
\n Describes a route table."
properties:
routes:
items:
description: Describes a route in a route table.
properties:
carrierGatewayID:
type: string
destinationCIDRBlock:
type: string
destinationIPv6CIDRBlock:
type: string
destinationPrefixListID:
type: string
egressOnlyInternetGatewayID:
type: string
gatewayID:
type: string
instanceID:
type: string
instanceOwnerID:
type: string
localGatewayID:
type: string
natGatewayID:
type: string
networkInterfaceID:
type: string
origin:
type: string
state:
type: string
transitGatewayID:
type: string
vpcPeeringConnectionID:
type: string
type: object
type: array
tagSpecifications:
description: The tags to assign to the route table.
items:
Expand Down Expand Up @@ -165,43 +201,6 @@ spec:
routeTableID:
description: The ID of the route table.
type: string
routes:
description: The routes in the route table.
items:
description: Describes a route in a route table.
properties:
carrierGatewayID:
type: string
destinationCIDRBlock:
type: string
destinationIPv6CIDRBlock:
type: string
destinationPrefixListID:
type: string
egressOnlyInternetGatewayID:
type: string
gatewayID:
type: string
instanceID:
type: string
instanceOwnerID:
type: string
localGatewayID:
type: string
natGatewayID:
type: string
networkInterfaceID:
type: string
origin:
type: string
state:
type: string
transitGatewayID:
type: string
vpcPeeringConnectionID:
type: string
type: object
type: array
tags:
description: Any tags assigned to the route table.
items:
Expand Down
3 changes: 3 additions & 0 deletions pkg/resource/route_table/delta.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading