Generate Instance CRD

[brycahta]

Issue #, if available: aws-controllers-k8s/community#1196

Description of changes:

• Instance Controller create/delete functionality with smoke test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[brycahta]

I will be handling update/modify code as well as exceptions and TerminalConditions in the next PR. Until then, Instance is NOT able to achieve ResourceSynced state because of "rolling" late initialization for fields such as BlockDeviceMappings.

Detailed Details

• If a user does not specify BlockDeviceMappings in the Spec, then neither the Create Response nor the subsequent Describe Response contains a populated BlockDeviceMappings field (good!)
• After multiple Describe calls (usually by the 3rd call here: https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/reconciler.go#L237 because LateInit is enabled), the BlockDeviceMappings field is eventually updated with a server-side value, ex:

//prev
BlockDeviceMappings: []

//updated
BlockDeviceMappings: [{
              DeviceName: "/dev/xvda",
              Ebs: {
                AttachTime: 2022-05-25 17:20:03 +0000 UTC,
                DeleteOnTermination: true,
                Status: "attaching",
                VolumeId: "vol-008cf94ebf53b06ec"
              }
            }],

• This triggers an update (not yet impl) and thus resource does not reach Sync state.
• Note, I have tried LateInitializing BlockDeviceMappings, but per the first point it does not apply here.

[RedbackThomson]

I just want to make sure we're not duplicating fields between Spec and Status. I saw VPCID defined in Status, but I don't see it defined in Spec - which makes me wonder how I would set this value in the first place.

Also left a comment inline about testing methodology.

[brycahta]

I saw VPCID defined in Status, but I don't see it defined in Spec - which makes me wonder how I would set this value in the first place.

Good catch! By default, RunInstances API will use the default VPC and a random subnet. If you want to select which VPC+Subnet to use, then the subnetID needs to be specified in the request. Basically there's no way to pass a VPCID in the request. https://docs.aws.amazon.com/cli/latest/reference/ec2/run-instances.html

[brycahta]

/retest

[RedbackThomson]

Great job!

[RedbackThomson]

nit: Move into a constant

[vijtrip2]

/lgtm

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RedbackThomson,brycahta,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment